RE: [PATCH 1/1] spi: pxa2xx: add driver enabling message
From: Flavio Suligoi
Date: Wed Apr 10 2019 - 07:47:50 EST
> On Mon, Apr 08, 2019 at 05:22:44PM +0200, Flavio Suligoi wrote:
> > Add an info message for the PXA2xx device driver start-up,
> > with the indication of the transfer mode used (DMA or GPIO).
> > This info is useful to individuate the timing when
> > the module starts.
> Adding this sort of message to every driver is going to make boot far
> too noisy, it's one thing if we actually enumerate information about the
> physical device but this isn't really that. There are already prints in
> the driver core for when things get probed which can be enabled if
> ordering issues need to be debugged.
You have right about to avoid too many boot messages,
but in this case, using an x86 machine and with
the spi-pxa2xx in DMA mode, so without the message:
"no DMA channels available, using PIO",
there is absolutely no indication about the existence
of the SPI master controller.
This is the first reason for this patch.
The second reason is about the DMA/PIO mode indication.
With the board I'm using, sometimes the spi-pxa2xx driver can't allocate
a DMA channel and works in PIO mode.
So, with the advice of Jarkko, I think that a valid solution could be:
1) remove the "no DMA channels available, using PIO" message
2) add a new message with the indications of:
- controller mode (slave or master)
- transfer mode (DMA or PIO)
What do you think about this?