Re: [PATCH v5 2/2] tty: serial: add driver for the SiFive UART

From: Kevin Hilman
Date: Thu May 02 2019 - 14:58:39 EST

Paul Walmsley <paul.walmsley@xxxxxxxxxx> writes:

> Add a serial driver for the SiFive UART, found on SiFive FU540 devices
> (among others).
> The underlying serial IP block is relatively basic, and currently does
> not support serial break detection. Further information on the IP
> block can be found in the documentation and Chisel sources:
> This driver was written in collaboration with Wesley Terpstra
> <wesley@xxxxxxxxxx>.
> Tested on a SiFive HiFive Unleashed A00 board, using BBL and the open-
> source FSBL (using a DT file based on what's targeted for mainline).
> This revision incorporates changes based on comments by Julia Lawall
> <julia.lawall@xxxxxxx>, Emil Renner Berthing <kernel@xxxxxxxx>, and
> Andreas Schwab <schwab@xxxxxxx>. Thanks also to Andreas for testing
> the driver with his userspace and reporting a bug with the
> set_termios implementation.
> Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxx>
> Cc: Wesley Terpstra <wesley@xxxxxxxxxx>
> Cc: linux-serial@xxxxxxxxxxxxxxx
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Julia Lawall <julia.lawall@xxxxxxx>
> Cc: Emil Renner Berthing <kernel@xxxxxxxx>
> Cc: Andreas Schwab <schwab@xxxxxxx>

Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>