Re: [PATCH 3/4] nvme-pci: add device coredump support

[Minwoo Im]

On 5/4/19 11:26 PM, Akinobu Mita wrote:
> 2019å5æ4æ(å) 19:04 Minwoo Im <minwoo.im.dev@xxxxxxxxx>:
> > Hi, Akinobu,
> >
> > Regardless to reply of the cover, few nits here.
> >
> > On 5/2/19 5:59 PM, Akinobu Mita wrote:
> > > +
> > > +static const struct nvme_reg nvme_regs[] = {
> > > +     { NVME_REG_CAP,         "cap",          64 },
> > > +     { NVME_REG_VS,          "version",      32 },
> >
> > Why don't we just go with "vs" instead of full name of it just like
> > the others.
>
> I tried to imitate the output of 'nvme show-regs'.

Okay.

> > > +     { NVME_REG_INTMS,       "intms",        32 },
> > > +     { NVME_REG_INTMC,       "intmc",        32 },
> > > +     { NVME_REG_CC,          "cc",           32 },
> > > +     { NVME_REG_CSTS,        "csts",         32 },
> > > +     { NVME_REG_NSSR,        "nssr",         32 },
> > > +     { NVME_REG_AQA,         "aqa",          32 },
> > > +     { NVME_REG_ASQ,         "asq",          64 },
> > > +     { NVME_REG_ACQ,         "acq",          64 },
> > > +     { NVME_REG_CMBLOC,      "cmbloc",       32 },
> > > +     { NVME_REG_CMBSZ,       "cmbsz",        32 },
> >
> > If it's going to support optional registers also, then we can have
> > BP-related things (BPINFO, BPRSEL, BPMBL) here also.
>
> I'm going to change the register dump in binary format just like
> 'nvme show-regs -o binary' does.  So we'll have registers from 00h to 4Fh.

Got it.

And now I can see those two commands `nvme show-regs` and
`nvme show-regs -o binary` have different results for the register
range.  The binary output covers just 0x50 size, but it shows all the
registers including BP-related things in normal && json format.

Anyway, I'll prepare a patch for nvme-cli to support binary output
format to cover BP things also.

Thanks, for your reply.