Re: [PATCH 3/4] nvme-pci: add device coredump support

[Minwoo Im]

On 5/4/19 11:38 PM, Minwoo Im wrote:
> On 5/4/19 11:26 PM, Akinobu Mita wrote:
> > 2019å5æ4æ(å) 19:04 Minwoo Im <minwoo.im.dev@xxxxxxxxx>:

> > > > +ÂÂÂÂ { NVME_REG_INTMS,ÂÂÂÂÂÂ "intms",ÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_INTMC,ÂÂÂÂÂÂ "intmc",ÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_CC,ÂÂÂÂÂÂÂÂÂ "cc",ÂÂÂÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_CSTS,ÂÂÂÂÂÂÂ "csts",ÂÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_NSSR,ÂÂÂÂÂÂÂ "nssr",ÂÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_AQA,ÂÂÂÂÂÂÂÂ "aqa",ÂÂÂÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_ASQ,ÂÂÂÂÂÂÂÂ "asq",ÂÂÂÂÂÂÂÂÂ 64 },
> > > > +ÂÂÂÂ { NVME_REG_ACQ,ÂÂÂÂÂÂÂÂ "acq",ÂÂÂÂÂÂÂÂÂ 64 },
> > > > +ÂÂÂÂ { NVME_REG_CMBLOC,ÂÂÂÂÂ "cmbloc",ÂÂÂÂÂÂ 32 },
> > > > +ÂÂÂÂ { NVME_REG_CMBSZ,ÂÂÂÂÂÂ "cmbsz",ÂÂÂÂÂÂÂ 32 },
> > >
> > > If it's going to support optional registers also, then we can have
> > > BP-related things (BPINFO, BPRSEL, BPMBL) here also.
> >
> > I'm going to change the register dump in binary format just like
> > 'nvme show-regs -o binary' does. So we'll have registers from 00h to 
> > 4Fh.
>
> Got it.
>
> And now I can see those two commands `nvme show-regs` and
> `nvme show-regs -o binary` have different results for the register
> range. The binary output covers just 0x50 size, but it shows all the
> registers including BP-related things in normal && json format.
>
> Anyway, I'll prepare a patch for nvme-cli to support binary output
> format to cover BP things also.
>
> Thanks, for your reply.

My bad, I misunderstood what you have said above.  Please ignore
what I mentioned. BP things are located from 40h. to 4Fh.

Sorry for making noises here. ;)