Re: [PATCH] fs: make all new mount api fds cloexec by default

[Christian Brauner]

On May 8, 2019 4:05:43 PM GMT+02:00, David Howells <dhowells@xxxxxxxxxx> wrote:
>Christian Brauner <christian@xxxxxxxxxx> wrote:
>
>> -	fd = get_unused_fd_flags(flags & O_CLOEXEC);
>> +	fd = get_unused_fd_flags(flags | O_CLOEXEC);
>
>That'll break if there are any flags other than O_CLOEXEC.
>
>> -	ret = get_unused_fd_flags((flags & FSMOUNT_CLOEXEC) ? O_CLOEXEC :
>0);
>> +	ret = get_unused_fd_flags(flags | O_CLOEXEC);
>
>That'll break because flags is not compatible with what
>get_unused_fd_flags()
>is expecting.

Technically only when new flags are added.
Right now it works correctly.
I'll send a v1 soon.

Thanks for catching that, David.
Christian