Re: [PATCH net] net: stmmac: fix ethtool flow control not able to get/set

From: David Miller
Date: Mon May 20 2019 - 20:57:43 EST


From: Weifeng Voon <weifeng.voon@xxxxxxxxx>
Date: Tue, 21 May 2019 12:55:42 +0800

> From: "Tan, Tee Min" <tee.min.tan@xxxxxxxxx>
>
> Currently ethtool was not able to get/set the flow control due to a
> missing "!". It will always return -EOPNOTSUPP even the device is
> flow control supported.
>
> This patch fixes the condition check for ethtool flow control get/set
> function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.
>
> Fixes: 3c1bcc8614db (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”)
> Signed-off-by: Tan, Tee Min <tee.min.tan@xxxxxxxxx>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>
> Signed-off-by: Voon, Weifeng <weifeng.voon@xxxxxxxxx@intel.com>

Applied and queued up for -stable.