Re: [PATCH net] net: stmmac: dma channel control register need to be init first

From: David Miller
Date: Mon May 20 2019 - 20:59:14 EST


From: Weifeng Voon <weifeng.voon@xxxxxxxxx>
Date: Tue, 21 May 2019 13:38:38 +0800

> stmmac_init_chan() needs to be called before stmmac_init_rx_chan() and
> stmmac_init_tx_chan(). This is because if PBLx8 is to be used,
> "DMA_CH(#i)_Control.PBLx8" needs to be set before programming
> "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL".
>
> Fixes: 47f2a9ce527a ("net: stmmac: dma channel init prepared for multiple queues")
> Reviewed-by: Zhang, Baoli <baoli.zhang@xxxxxxxxx>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>
> Signed-off-by: Weifeng Voon <weifeng.voon@xxxxxxxxx>

Applied and queued up for -stable.

Thanks.