Re: [PATCH] sched/core: add __sched tag for io_schedule()

From: Gao Xiang
Date: Mon Jun 03 2019 - 05:05:09 EST


Hi Peter,

On 2019/6/3 16:58, Peter Zijlstra wrote:
> On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
>> non-inline io_schedule() was introduced in
>> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
>> Keep in line with io_schedule_timeout, Otherwise
>> "/proc/<pid>/wchan" will report io_schedule()
>> rather than its callers when waiting io.
>>
>> Reported-by: Jilong Kou <koujilong@xxxxxxxxxx>
>> Cc: Tejun Heo <tj@xxxxxxxxxx>
>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>
> This is lacking a Fixes: tag.
>

OK, thanks for pointing out. It seems enough to resend this patch.
I will resend this patch with all necessary tags.

Thanks,
Gao Xiang