RE: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver

[Anson Huang]

> -----Original Message-----
> From: Leonard Crestez
> Sent: Monday, June 3, 2019 4:45 PM
> To: Anson Huang <anson.huang@xxxxxxx>; mturquette@xxxxxxxxxxxx;
> sboyd@xxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; catalin.marinas@xxxxxxx; will.deacon@xxxxxxx;
> maxime.ripard@xxxxxxxxxxx; olof@xxxxxxxxx; horms+renesas@xxxxxxxxxxxx;
> jagan@xxxxxxxxxxxxxxxxxxxx; bjorn.andersson@xxxxxxxxxx;
> dinguyen@xxxxxxxxxx; enric.balletbo@xxxxxxxxxxxxx; Aisheng Dong
> <aisheng.dong@xxxxxxx>; Jacky Bai <ping.bai@xxxxxxx>; Abel Vesa
> <abel.vesa@xxxxxxx>; l.stach@xxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
> 
> On 6/3/2019 4:33 AM, Anson.Huang@xxxxxxx wrote:
> > From: Anson Huang <Anson.Huang@xxxxxxx>
> >
> > This patch adds i.MX8MN clock driver support.
> 
> > +#include "clk.h"
> > +
> > +#define PLL_1416X_RATE(_rate, _m, _p, _s)		\
> > +	{						\
> > +		.rate	=	(_rate),		\
> > +		.mdiv	=	(_m),			\
> > +		.pdiv	=	(_p),			\
> > +		.sdiv	=	(_s),			\
> > +	}
> > +
> > +#define PLL_1443X_RATE(_rate, _m, _p, _s, _k)		\
> > +	{						\
> > +		.rate	=	(_rate),		\
> > +		.mdiv	=	(_m),			\
> > +		.pdiv	=	(_p),			\
> > +		.sdiv	=	(_s),			\
> > +		.kdiv	=	(_k),			\
> > +	}
> 
> These macros are shared with clk-imx8mm (and perhaps some future chips)
> so they should be moved to driver/clk/imx/clk.h

OK, will move them into clk.h in V3.

Anson.