Re: [PATCH] x86/cpu: Add Icelake-NNPI to Intel family

[Bhardwaj, Rajneesh]

Hi Andy

On 04-Jun-19 9:39 PM, Andy Shevchenko wrote:
> On Thu, May 30, 2019 at 06:08:27PM +0530, Rajneesh Bhardwaj wrote:
> > Add the CPUID model number of Icelake Neural Network Processor for Deep
> I believe we spell "Ice Lake".

I referred to https://patchwork.kernel.org/patch/10812551/ , 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e394376ee89233508fa21d006546357f8efee31 
and many others where it mentioned Icelake. I am fine to change it the 
way you are suggesting, please confirm if its still needed and i will 
send a v2.

Thank you.

> > Learning Inference (ICL-NNPI) to the Intel family list. Icelake NNPI uses
> Ditto.
>
> > model number 0x9D and this will be documented in a future version of Intel
> > Software Development Manual.
> >
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx
> > Cc: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Cc: Len Brown <lenb@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: x86-ml <x86@xxxxxxxxxx>
> > Cc: Linux PM <linux-pm@xxxxxxxxxxxxxxx>
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxxxxxxxx>
> > ---
> >   arch/x86/include/asm/intel-family.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> > index 9f15384c504a..087de5d3b93a 100644
> > --- a/arch/x86/include/asm/intel-family.h
> > +++ b/arch/x86/include/asm/intel-family.h
> > @@ -53,6 +53,7 @@
> >   #define INTEL_FAM6_CANNONLAKE_MOBILE	0x66
> >   
> >   #define INTEL_FAM6_ICELAKE_MOBILE	0x7E
> > +#define INTEL_FAM6_ICELAKE_NNPI		0x9D
> >   
> >   /* "Small Core" Processors (Atom) */
> >   
> > --
> > 2.17.1