Re: [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()

From: John Hubbard
Date: Tue Jun 04 2019 - 15:33:55 EST

On 6/3/19 4:56 PM, Ira Weiny wrote:
> On Mon, Jun 03, 2019 at 09:42:06AM -0700, Christoph Hellwig wrote:
>>> +#if defined(CONFIG_CMA)
>> You can just use #ifdef here.
>>> +static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
>>> + struct page **pages)
>> Please use two instead of one tab to indent the continuing line of
>> a function declaration.
>>> +{
>>> + if (unlikely(gup_flags & FOLL_LONGTERM)) {
>> IMHO it would be a little nicer if we could move this into the caller.
> FWIW we already had this discussion and thought it better to put this here.
> Ira
> [PS John for some reason your responses don't appear in that thread?]

Thanks for pointing out the email glitches! It looks like it's making it over to, but not to, nor to the
section either:

...and I've already checked the DKIM signatures, they're all good. So I think this
is getting narrowed down to, messages from (or at least from me) are not
making it onto the lkml list server. I'm told that this can actually happen *because*
of DKIM domains: list servers may try to avoid retransmitting from DKIM domains. sigh.

Any hints are welcome, otherwise I'll try to locate the lkml admins and see what can
be done.

(+Sanket, Ralph from our email team)

John Hubbard