Re: [PATCH v5 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL

[Popa, Stefan Serban]

Hi Rob,

I'm sorry I forgot to include your Reviewed-by in this patch series.
However, I realized this mistake and added it to v6 which in the meantime
Jonathan has applied.

I will fix your remark bellow regarding clock-names in the next patch
series for this device.

Thank you,
-Stefan

On Ma, 2019-06-11 at 15:59 -0600, Rob Herring wrote:
> 
> 
> On Tue, Jun 04, 2019 at 04:08:17PM +0300, Stefan Popa wrote:
> > 
> > Document support for Analog Devices ADF4371 SPI Wideband Synthesizer.
> > 
> > Signed-off-by: Stefan Popa <stefan.popa@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > ÂÂÂÂÂÂ- Nothing changed.
> > Changes in v3:
> > ÂÂÂÂÂÂ- Nothing changed.
> > Changes in v4:
> > ÂÂÂÂÂÂ- Nothing changed.
> > Changes in v5:
> > ÂÂÂÂÂÂ- Nothing changed.
> Please add acks/reviewed-bys when posting new versions.
> 
> But something else I noticed:
> 
> > 
> > 
> > Â.../devicetree/bindings/iio/frequency/adf4371.yaml | 54
> > ++++++++++++++++++++++
> > Â1 file changed, 54 insertions(+)
> > Âcreate mode 100644
> > Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > new file mode 100644
> > index 0000000..d7adf074
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/frequency/adf4371.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices ADF4371 Wideband Synthesizer
> > +
> > +maintainers:
> > +ÂÂ- Popa Stefan <stefan.popa@xxxxxxxxxx>
> > +
> > +description: |
> > +ÂÂAnalog Devices ADF4371 SPI Wideband Synthesizer
> > +ÂÂhttps://www.analog.com/media/en/technical-documentation/data-sheets/
> > adf4371.pdf
> > +
> > +properties:
> > +ÂÂcompatible:
> > +ÂÂÂÂenum:
> > +ÂÂÂÂÂÂ- adi,adf4371
> > +
> > +ÂÂreg:
> > +ÂÂÂÂmaxItems: 1
> > +
> > +ÂÂclocks:
> > +ÂÂÂÂdescription:
> > +ÂÂÂÂÂÂDefinition of the external clock (see clock/clock-bindings.txt)
> > +ÂÂÂÂmaxItems: 1
> > +
> > +ÂÂclock-names:
> > +ÂÂÂÂdescription:
> > +ÂÂÂÂÂÂMust be "clkin"
> This can be a schema:
> 
> clock-names:
> Â items:
> ÂÂÂÂ- clkin
> 
> > 
> > +ÂÂÂÂmaxItems: 1
> > +
> > +required:
> > +ÂÂ- compatible
> > +ÂÂ- reg
> > +ÂÂ- clocks
> > +ÂÂ- clock-names
> > +
> > +examples:
> > +ÂÂ- |
> > +ÂÂÂÂspi0 {
> > +ÂÂÂÂÂÂÂÂ#address-cells = <1>;
> > +ÂÂÂÂÂÂÂÂ#size-cells = <0>;
> > +
> > +ÂÂÂÂÂÂÂÂfrequency@0 {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcompatible = "adi,adf4371";
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreg = <0>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂspi-max-frequency = <1000000>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂclocks = <&adf4371_clkin>;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂclock-names = "clkin";
> > +ÂÂÂÂÂÂÂÂ};
> > +ÂÂÂÂ};
> > +...
> > --
> > 2.7.4
> >