Re: [PATCH v3 1/5] gem/vram: pin to vram in vmap

From: Gerd Hoffmann
Date: Thu Jun 27 2019 - 11:16:42 EST


Hi,

> 1) Introduce a default_placement field in struct drm_gem_vram_helper
> where this flag can be configured. I'd favor this option.

> 2) Introduce a separate callback function for pinning to vram. The
> driver would have to set the correct function pointers.

> 3) Pin the fb console buffer manually from within the bochs driver.

Hmm. Before calling drm_fbdev_generic_setup() the bo doesn't exist yet
and when the function returns it is already vmapped and pinned I think.

So (3) isn't easily doable. (1) looks best to me.

cheers,
Gerd