Re: [PATCH v3 1/5] gem/vram: pin to vram in vmap

[Thomas Zimmermann]

Hi

Am 27.06.19 um 17:16 schrieb Gerd Hoffmann:
>   Hi,
> 
>>  1) Introduce a default_placement field in struct drm_gem_vram_helper
>> where this flag can be configured. I'd favor this option.
> 
>>  2) Introduce a separate callback function for pinning to vram. The
>> driver would have to set the correct function pointers.
> 
>>  3) Pin the fb console buffer manually from within the bochs driver.
> 
> Hmm.  Before calling drm_fbdev_generic_setup() the bo doesn't exist yet
> and when the function returns it is already vmapped and pinned I think.
> 
> So (3) isn't easily doable.  (1) looks best to me.

For my patches, it's OK to have to BO pinned to VRAM by default. As the
BO will be unmapped most of the time, I can change this flag at any time.

Best regards
Thomas

> cheers,
>   Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix ImendÃrffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG NÃrnberg)

Attachment: signature.asc
Description: OpenPGP digital signature