Re: [PATCH] riscv: ccache: Remove unused variable

From: Paul Walmsley
Date: Thu Jun 27 2019 - 12:13:59 EST


On Thu, 27 Jun 2019, Yash Shah wrote:

> Reading the count register clears the interrupt signal. Currently, the
> count registers are read into 'regval' variable but the variable is
> never used. Therefore remove it.
>
> Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>

This is a good start. Could you also add comments in the code that
describe what those reads are doing, as you did in the patch description?
Otherwise they look pretty mysterious.


- Paul