Re: [PATCH] riscv: ccache: Remove unused variable
From: Yash Shah
Date: Fri Jun 28 2019 - 00:56:28 EST
On Thu, Jun 27, 2019 at 9:43 PM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
>
> On Thu, 27 Jun 2019, Yash Shah wrote:
>
> > Reading the count register clears the interrupt signal. Currently, the
> > count registers are read into 'regval' variable but the variable is
> > never used. Therefore remove it.
> >
> > Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>
>
> This is a good start. Could you also add comments in the code that
> describe what those reads are doing, as you did in the patch description?
> Otherwise they look pretty mysterious.
>
Sure, will add comments and send v2
>
> - Paul