Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button
From: Andy Shevchenko
Date: Thu Jul 25 2019 - 14:57:55 EST
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
<lkml@xxxxxxxxx> wrote:
>
> On 25.07.19 19:17, Andy Shevchenko wrote:
> > On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> > <info@xxxxxxxxx> wrote:
> >>
> >> From: Enrico Weigelt <info@xxxxxxxxx>
> >>
> >> The keycode KEY_RESTART is more appropriate for the front button,
> >> as most people use it for things like restart or factory reset.
> >>
> >
> > Should it go as Fixes?
>
> I think so. Technically, the feature already worked, but the keycode
> wasn't semantically fine.
Can you provide a Fixes tag?
--
With Best Regards,
Andy Shevchenko