Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front button

From: Enrico Weigelt, metux IT consult
Date: Thu Jul 25 2019 - 15:06:28 EST


On 25.07.19 20:57, Andy Shevchenko wrote:
On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
<lkml@xxxxxxxxx> wrote:

On 25.07.19 19:17, Andy Shevchenko wrote:
On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
<info@xxxxxxxxx> wrote:

From: Enrico Weigelt <info@xxxxxxxxx>

The keycode KEY_RESTART is more appropriate for the front button,
as most people use it for things like restart or factory reset.


Should it go as Fixes?

I think so. Technically, the feature already worked, but the keycode
wasn't semantically fine.

Can you provide a Fixes tag?


Okay, sent a v2.


--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287