Re: [PATCH v5 03/10] rtc: mt6397: move some common definitions into rtc.h

From: Alexandre Belloni
Date: Mon Aug 12 2019 - 11:39:03 EST


On 12/08/2019 16:11:29+0100, Lee Jones wrote:
> On Mon, 12 Aug 2019, Frank Wunderlich wrote:
>
> > From: Josef Friedl <josef.friedl@xxxxxxxx>
> >
> > move code to separate header-file to reuse definitions later
> > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c)
> >
> > Suggested-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > Signed-off-by: Josef Friedl <josef.friedl@xxxxxxxx>
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > ---
> > changes since v4: none
> > changes since v3: none
> > changes since v2: add missing commit-message
> > ---
> > drivers/rtc/rtc-mt6397.c | 55 +-------------------------
> > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++
>
> include/linux/rtc/mt6397.h?
>

It's just a bunch of registers and bit definitions so it may as well
stay close to include/linux/mfd/mt6397/registers.h


--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com