Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall

From: Max Staudt
Date: Mon Aug 12 2019 - 11:39:51 EST


On 08/12/2019 05:01 PM, Bartlomiej Zolnierkiewicz wrote:
>> Unfortunately, pata_buddha_exit() is void, and thus can't fail. According to Documentation/kernel-hacking/hacking.rst this is by design.
>
> You are of course right and the example code is broken
> (+ I need more caffeine).

Hey! That's usually my line to say!

I'm just glad I didn't miss something obvious here...


>> Any other ideas? We could also continue to disallow unloading completely until MFD support comes along.
> Yes, this would also be OK.

Okay, I will refresh the patch accordingly.

Thanks for your help!
Max