Re: [PATCH 1/3] bus: fsl-mc: remove explicit device_link_del

From: Li Yang
Date: Thu Aug 15 2019 - 19:13:21 EST


On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei <ioana.ciornei@xxxxxxx> wrote:
>
> Starting with commit 72175d4ea4c4 ("driver core: Make driver core own
> stateful device links") stateful device links are owned by the driver
> core and should not be explicitly removed on device unbind. Delete all
> device_link_del appearances from the fsl-mc bus.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>

Hi Laurentiu,

What do you think of this patches? I can take it through fsl/soc if
you can ACK it.

Regards,
Leo

> ---
> drivers/bus/fsl-mc/fsl-mc-allocator.c | 1 -
> drivers/bus/fsl-mc/mc-io.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> index 8ad77246f322..cc7bb900f524 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> @@ -330,7 +330,6 @@ void fsl_mc_object_free(struct fsl_mc_device *mc_adev)
>
> fsl_mc_resource_free(resource);
>
> - device_link_del(mc_adev->consumer_link);
> mc_adev->consumer_link = NULL;
> }
> EXPORT_SYMBOL_GPL(fsl_mc_object_free);
> diff --git a/drivers/bus/fsl-mc/mc-io.c b/drivers/bus/fsl-mc/mc-io.c
> index 3ae574a58cce..d9629fc13a15 100644
> --- a/drivers/bus/fsl-mc/mc-io.c
> +++ b/drivers/bus/fsl-mc/mc-io.c
> @@ -255,7 +255,6 @@ void fsl_mc_portal_free(struct fsl_mc_io *mc_io)
> fsl_destroy_mc_io(mc_io);
> fsl_mc_resource_free(resource);
>
> - device_link_del(dpmcp_dev->consumer_link);
> dpmcp_dev->consumer_link = NULL;
> }
> EXPORT_SYMBOL_GPL(fsl_mc_portal_free);
> --
> 1.9.1
>