Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error
From: Stephen Boyd
Date: Fri Sep 06 2019 - 01:15:30 EST
Quoting YueHaibing (2019-09-05 20:30:06)
> When do coccicheck, I get this error:
>
> spatch -D report --no-show-diff --very-quiet --cocci-file
> ./scripts/coccinelle/api/platform_get_irq.cocci --include-headers
> --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
> -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
> -I ./include/uapi -I ./include/generated/uapi
> --include ./include/linux/kconfig.h --jobs 192 --chunksize 1
> minus: parse error:
> File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
> around = '\(',
> whole content = if ( ret \( < \| <= \) 0 )
>
> In commit e56476897448 ("fpga: Remove dev_err() usage
> after platform_get_irq()") log, I found the semantic patch,
> it fix this issue.
>
> Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
Hmm I had this earlier but someone asked me to change it.
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>