Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error

[Markus Elfring]

> > minus: parse error:
> >   File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
> >   around = '\(',
> >   whole content = if ( ret \( < \| <= \) 0 )
> >
> > In commit e56476897448 ("fpga: Remove dev_err() usage
> > after platform_get_irq()") log, I found the semantic patch,
> > it fix this issue.
> >
> > Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> > ---
>
> Hmm I had this earlier but someone asked me to change it.

I proposed something also during the development for this SmPL script.
https://lkml.org/lkml/2019/7/24/274
https://lore.kernel.org/r/c98b8f50-1adf-ea95-a91c-ec451e9fefe2@xxxxxx/


> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Should disjunctions eventually work in the semantic patch language also together with
comparison operators?
https://github.com/coccinelle/coccinelle/issues/40


Will any additional software adjustments be taken into account?

Regards,
Markus