RE: [PATCH] kunit: add PRINTK dependency
From: Tim.Bird
Date: Fri Sep 06 2019 - 11:31:39 EST
Minor spelling nit..
> -----Original Message-----
> From: Arnd Bergmann
>
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
>
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-
> Werror,-Wimplicit-function-declaration]
>
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
depenedency -> dependency
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> kunit/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
>
> config KUNIT
> bool "Enable support for unit tests (KUnit)"
> + depends on PRINTK
> help
> Enables support for kernel unit tests (KUnit), a lightweight unit
> testing and mocking framework for the Linux kernel. These tests are
> --
> 2.20.0