Re: [PATCH] unicode: make array 'token' static const, makes object smaller

From: Theodore Y. Ts'o
Date: Fri Sep 06 2019 - 11:31:57 EST


On Fri, Sep 06, 2019 at 02:58:07PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the array 'token' on the stack but instead make it
> static const. Makes the object code smaller by 234 bytes.
>
> Before:
> text data bss dec hex filename
> 5371 272 0 5643 160b fs/unicode/utf8-core.o
>
> After:
> text data bss dec hex filename
> 5041 368 0 5409 1521 fs/unicode/utf8-core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Nice, thanks!

Reviewed-by: Theodore Ts'o <tytso@xxxxxxx>

- Ted