RE: [PATCH 0/2] nvme: Add kernel API for admin command

[Baldyga, Robert]

On Fri, Sep 13, 2019 at 04:37:09PM +0200, Christoph Hellwig wrote:
> On Fri, Sep 13, 2019 at 01:16:08PM +0200, Robert Baldyga wrote:
> > Hello,
> > 
> > This patchset adds two functions providing kernel to kernel API 
> > for submiting NVMe admin commands. This is for use of NVMe-aware
> > block device drivers stacking on top of NVMe drives. An example of
> > such driver is Open CAS Linux [1] which uses NVMe extended LBA 
> > formats and thus needs to issue commands like nvme_admin_identify.
> 
> We never add functionality for out of tree crap.  And this shit really
> is a bunch of crap, so it is unlikely to ever be merged. 

So that modules which are by design out of tree have to hack around
lack of API allowing to use functionality implemented by driver.
Don't you think that this is what actually produces crap?

> Why can't intel sometimes actually do something useful for a change
> instead of piling junk over junk?

Proposed API is equally useful for both in tree and out of tree modules,
so I find your comment unrelated.

If you don't like the way it's done, we can look for alternatives.
The point is to allow other drivers use NVMe admin commands, which is
currently not possible as neither the block layer nor the nvme driver
provides sufficient API.

Best regards,
Robert Baldyga
--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.