Re: [PATCH v2 2/2] powerpc/83xx: map IMMR with a BAT.

[Christophe Leroy]

Le 16/09/2019 Ã 17:04, Scott Wood a ÃcritÂ:
> On Mon, 2019-09-16 at 06:42 +0000, Christophe Leroy wrote:
> > @@ -145,6 +147,15 @@ void __init mpc83xx_setup_arch(void)
> >   	if (ppc_md.progress)
> >   		ppc_md.progress("mpc83xx_setup_arch()", 0);
> >   
> > +	if (!__map_without_bats) {
> > +		phys_addr_t immrbase = get_immrbase();
> > +		int immrsize = IS_ALIGNED(immrbase, SZ_2M) ? SZ_2M : SZ_1M;
> > +		unsigned long va = __fix_to_virt(FIX_IMMR_BASE);
>
> Why __fix_to_virt() and not fix_to_virt()?

Euh ... because I copy/pasted it from 
/arch/powerpc/include/asm/nohash/32/mmu-8xx.h

But yes I can do fix_to_virt() instead.

Christophe