Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args

From: Ingo Molnar
Date: Tue Sep 17 2019 - 03:49:16 EST



* Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote:

> The addition of struct clone_args to uapi/linux/sched.h is not
> protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
> RISC-V. Add the guards to fix this.
>
> Fixes: 7f192e3cd316 ("fork: add clone3")
> Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> ---
> include/uapi/linux/sched.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index b3105ac1381a..851ff1feadd5 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -33,6 +33,7 @@
> #define CLONE_NEWNET 0x40000000 /* New network namespace */
> #define CLONE_IO 0x80000000 /* Clone io context */
>
> +#ifndef __ASSEMBLY__
> /*
> * Arguments for the clone3 syscall
> */
> @@ -46,6 +47,7 @@ struct clone_args {
> __aligned_u64 stack_size;
> __aligned_u64 tls;
> };
> +#endif

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo