Re: linux-next: Tree for Sep 16 (kernel/sched/core.c)

From: Ingo Molnar
Date: Tue Sep 17 2019 - 03:52:49 EST



* Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 9/16/19 3:38 PM, Mark Brown wrote:
> > Hi all,
> >
> > Changes since 20190915:
> >
>
> on x86_64:
>
> when CONFIG_CGROUPS is not set:
>
> CC kernel/sched/core.o
> ../kernel/sched/core.c: In function âuclamp_update_active_tasksâ:
> ../kernel/sched/core.c:1081:23: error: storage size of âitâ isnât known
> struct css_task_iter it;
> ^~
> CC kernel/printk/printk_safe.o
> ../kernel/sched/core.c:1084:2: error: implicit declaration of function âcss_task_iter_startâ; did you mean â__sg_page_iter_startâ? [-Werror=implicit-function-declaration]
> css_task_iter_start(css, 0, &it);
> ^~~~~~~~~~~~~~~~~~~
> __sg_page_iter_start
> ../kernel/sched/core.c:1085:14: error: implicit declaration of function âcss_task_iter_nextâ; did you mean â__sg_page_iter_nextâ? [-Werror=implicit-function-declaration]
> while ((p = css_task_iter_next(&it))) {
> ^~~~~~~~~~~~~~~~~~
> __sg_page_iter_next
> ../kernel/sched/core.c:1091:2: error: implicit declaration of function âcss_task_iter_endâ; did you mean âget_task_credâ? [-Werror=implicit-function-declaration]
> css_task_iter_end(&it);
> ^~~~~~~~~~~~~~~~~
> get_task_cred
> ../kernel/sched/core.c:1081:23: warning: unused variable âitâ [-Wunused-variable]
> struct css_task_iter it;
> ^~
>

I cannot reproduce this build failue: I took Linus's latest which has all
the -next scheduler commits included (ad062195731b), and an x86-64 "make
defconfig" and a disabling of CONFIG_CGROUPS still resuls in a kernel
that builds fine.

Thanks,

Ingo