Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

[Ardelean, Alexandru]

On Tue, 2019-09-17 at 14:41 +0200, Andrew Lunn wrote:
> [External]
> 
> On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote:
> > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type',
> > which are enums of mode strings.
> > 
> > The 'dwmac' driver supports almost all modes declared in the 'phy-mode'
> > enum (except for 1 or 2). But in general, there may be a case where
> > 'mac-mode' becomes more generic and is moved as part of phylib or netdev.
> > 
> > In any case, the 'mac-mode' field should be made an enum, and it also makes
> > sense to just reference the 'phy-connection-type' from
> > 'ethernet-controller.yaml'. That will also make it more future-proof for new
> > modes.
> > 
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> 
> Hi Alexandru
> 
> Adding a Fixes: tag would be good. Just reply in this thread, and
> patchwork will do magic to append it to the patch.
> 

Oops. Good point.
Thanks for the tip.

Let's see if Rob agrees as well.

Fixes: 9c15d3597c62 ("dt-bindings: net: dwmac: document 'mac-mode' property")

> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> 
>     Andrew