Re: [PATCH] hw_random: don't wait on add_early_randomness()

From: Theodore Y. Ts'o
Date: Tue Sep 17 2019 - 11:37:00 EST


On Tue, Sep 17, 2019 at 11:54:50AM +0200, Laurent Vivier wrote:
> add_early_randomness() is called by hwrng_register() when the
> hardware is added. If this hardware and its module are present
> at boot, and if there is no data available the boot hangs until
> data are available and can't be interrupted.
>
> To avoid that, call rng_get_data() in non-blocking mode (wait=0)
> from add_early_randomness().
>
> Signed-off-by: Laurent Vivier <lvivier@xxxxxxxxxx>

Looks good, you can add:

Reviewed-by: Theodore Ts'o <tytso@xxxxxxx>