Re: [PATCH v2] selftests: watchdog: Validate optional file argument

[Eugeniu Rosca]

Shuah,

On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote:

[..]

> I want two patches and the first one with
> Fixes tag. 

I am not sure we are on the same page and you don't seem to be receptive
to what I say.

> The reason for that is that the first patch fixes a problem
> in patch that is already in my tree which is fixes a problem.

Here is my understanding of your request:

 +--------------+    +--------------+
 |1/2 this patch|    |1/2 this patch|
 |    (fix)     +----+  (feature)   |
 +------+-------+    +--------------+
        | Fixes
 +------v-------+
 |     [A]      |
 +------+-------+
        | Fixes
 +------v-------+
 |     [B]      |
 +--------------+

So, you ask to decompose this v2 patch into two parts (fix and feature),
__exactly like it was in v1__, with the reasoning that the bugfix
related part of this patch fixes [A] (which is true), while [A] fixes
another commit [B]. But given that [A] is a feature commit, adding brand
new functionality, there can't be any [B] commit being fixed by [A].

> I am going to mark the patch for stables and the first patch in this
> series.

I do not understand your request. Both current patch and [A] are
scheduled for v5.4. I do not see any relevant patches for linux-stable.
I hope either a clarification or a third opinion will shed more light
onto this totally unproductive dialogue.

[A] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c3f2490d6e92
    ("selftests: watchdog: Add optional file argument")
    https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=c3f2490d6e92
    ("selftests: watchdog: Add optional file argument")
[B] ???

-- 
Best Regards,
Eugeniu.