Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code

[Jingoo Han]

ïOn 9/4/19, 7:57 AM, YueHaibing wrote:

> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>
Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx>
>
> ---
>  drivers/video/fbdev/s3c-fb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index ba04d7a..43ac8d7 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>  
>  	pm_runtime_enable(sfb->dev);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sfb->regs = devm_ioremap_resource(dev, res);
> +	sfb->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sfb->regs)) {
>  		ret = PTR_ERR(sfb->regs);
>  		goto err_lcd_clk;
> -- 
> 2.7.4