Re: [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames

From: Chaitanya Kulkarni
Date: Tue Sep 17 2019 - 17:04:56 EST


Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
On 09/17/2019 09:52 AM, Paolo Valente wrote:
> From: Angelo Ruocco<angeloruocco90@xxxxxxxxx>
>
> When bfq was merged into mainline, there were two I/O schedulers that
> implemented the proportional-share policy: bfq for blk-mq and cfq for
> legacy blk. bfq's interface files in the blkio/io controller have the
> same names as cfq. But the cgroups interface doesn't allow two
> entities to use the same name for their files, so for bfq we had to
> prepend the "bfq" prefix to each of its files. However no legacy code
> uses these modified file names. This naming also causes confusion, as,
> e.g., in [1].
>
> Now cfq has gone with legacy blk, so there is no need any longer for
> these prefixes in (the never used) bfq names. In view of this fact, this
> commit removes these prefixes, thereby enabling legacy code to truly
> use the proportional share policy in blk-mq.
>
> [1]https://github.com/systemd/systemd/issues/7057
>
> Signed-off-by: Angelo Ruocco<angeloruocco90@xxxxxxxxx>
> Signed-off-by: Paolo Valente<paolo.valente@xxxxxxxxxx>