Re: [PATCH] drm: sun8i-ui/vi: Fix layer zpos change/atomic modesetting

From: Maxime Ripard
Date: Wed Sep 18 2019 - 10:17:39 EST


Hi,

On Sun, Sep 15, 2019 at 12:03:37AM +0200, megous@xxxxxxxxxx wrote:
> From: Ondrej Jirman <megous@xxxxxxxxxx>
>
> There are various issues that this re-work of sun8i_[uv]i_layer_enable
> function fixes:
>
> - Make sure that we re-initialize zpos on reset
> - Minimize register updates by doing them only when state changes
> - Fix issue where DE pipe might get disabled even if it is no longer
> used by the layer that's currently calling sun8i_ui_layer_enable
> - .atomic_disable callback is not really needed because .atomic_update
> can do the disable too, so drop the duplicate code
>
> Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>

It looks like these fixes should be in separate patches. Is there any
reason it's not the case?

Maxime

Attachment: signature.asc
Description: PGP signature