Re: [PATCH v7 09/13] lib/vsprintf: Add a note on re-using %pf or %pF

From: Sakari Ailus
Date: Wed Sep 18 2019 - 10:29:08 EST


On Wed, Sep 18, 2019 at 10:00:23AM -0400, Steven Rostedt wrote:
> On Wed, 18 Sep 2019 16:34:15 +0300
> Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> > Add a note warning of re-use of obsolete %pf or %pF extensions.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> Suggested-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Yes, I'll add that for v8.

>
> > ---
> > lib/vsprintf.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index b00b57f9f911f..df59818537b52 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -2008,6 +2008,8 @@ static char *kobject_string(char *buf, char *end, void *ptr,
> > * - 'S' For symbolic direct pointers (or function descriptors) with offset
> > * - 's' For symbolic direct pointers (or function descriptors) without offset
> > * - '[Ss]R' as above with __builtin_extract_return_addr() translation
> > + * - '[Ff]' Obsolete an now unsupported extension for printing direct pointers
>
> "Obsolete and now"?

Fixed.

--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx