Re: [GIT PULL] LED updates for 5.4-rc1

[Jacek Anaszewski]

On 9/18/19 9:23 AM, Andy Shevchenko wrote:
> On Wed, Sep 18, 2019 at 10:16 AM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Tue, Sep 17, 2019 at 6:13 PM Linus Torvalds
>> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>
>>> So this is fine and I've pulled it,
>>
>> Famous last words. I now get a new warning:
>>
>> drivers/i2c/i2c-core-acpi.c:347:12: warning:
>> âi2c_acpi_find_match_adapterâ defined but not used [-Wunused-function]
>>   347 | static int i2c_acpi_find_match_adapter(struct device *dev,
>> const void *data)
>>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> with this pull request.  I'll have to look at it after dinner.
>>
>>               Linus
> 
> One of those *device core* patch broke i2c ACPI, which has been fixed by
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/i2c/i2c-core-acpi.c?id=644bf60088955421051e716ab9c8fe7fb7997fd7
> 
> As I read above the merge commit didn't take this patch.

It's my bad that I didn't notice the warning, but after the problem
was caught and fixed it would have been good to notify all parties that
may have pulled broken commit.

> Solution might be to merge this PR after corresponding bundle of
> device core stuff.
> 

-- 
Best regards,
Jacek Anaszewski