Re: [PATCH] mfd: mt6360: add pmic mt6360 driver

[kbuild test robot]

Hi Gene,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190917]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gene-Chen/mfd-mt6360-add-pmic-mt6360-driver/20190918-181850
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from <command-line>:0:0:
   include/linux/mfd/mt6360-private.h: In function 'mt6360_dt_parser_helper':
   include/linux/mfd/mt6360-private.h:243:3: error: implicit declaration of function 'of_property_read_u32' [-Werror=implicit-function-declaration]
      of_property_read_u32(np, props[i].name, data + props[i].offset);
      ^~~~~~~~~~~~~~~~~~~~
   include/linux/mfd/mt6360-private.h: In function 'mt6360_pdata_apply_helper':
>> include/linux/mfd/mt6360-private.h:271:9: error: implicit declaration of function 'regmap_update_bits'; did you mean 'file_update_time'? [-Werror=implicit-function-declaration]
      ret = regmap_update_bits(context,
            ^~~~~~~~~~~~~~~~~~
            file_update_time
   cc1: some warnings being treated as errors

vim +271 include/linux/mfd/mt6360-private.h

   233	
   234	static inline void mt6360_dt_parser_helper(struct device_node *np, void *data,
   235						   const struct mt6360_val_prop *props,
   236						   int prop_cnt)
   237	{
   238		int i;
   239	
   240		for (i = 0; i < prop_cnt; i++) {
   241			if (unlikely(!props[i].name))
   242				continue;
 > 243			of_property_read_u32(np, props[i].name, data + props[i].offset);
   244		}
   245	}
   246	
   247	#define MT6360_PDATA_VALPROP(name, type, reg, shift, mask, func, base) \
   248				{offsetof(type, name), reg, shift, mask, func, base}
   249	
   250	struct mt6360_pdata_prop {
   251		size_t offset;
   252		u8 reg;
   253		u8 shift;
   254		u8 mask;
   255		u32 (*transform)(u32 val);
   256		u8 base;
   257	};
   258	
   259	static inline int mt6360_pdata_apply_helper(void *context, void *pdata,
   260						   const struct mt6360_pdata_prop *prop,
   261						   int prop_cnt)
   262	{
   263		int i, ret;
   264		u32 val;
   265	
   266		for (i = 0; i < prop_cnt; i++) {
   267			val = *(u32 *)(pdata + prop[i].offset);
   268			if (prop[i].transform)
   269				val = prop[i].transform(val);
   270			val += prop[i].base;
 > 271			ret = regmap_update_bits(context,
   272				     prop[i].reg, prop[i].mask, val << prop[i].shift);
   273			if (ret < 0)
   274				return ret;
   275		}
   276		return 0;
   277	}
   278	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip