[PATCH] PCI: Enhance the ACS quirk for Cavium devices

From: George Cherian
Date: Wed Sep 18 2019 - 22:43:46 EST


Enhance the ACS quirk for Cavium Processors. Add the root port
vendor ID's in an array and use the same in match function.
For newer devices add the vendor ID's in the array so that the
match function is simpler.

Signed-off-by: George Cherian <george.cherian@xxxxxxxxxxx>
---
drivers/pci/quirks.c | 28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 44c4ae1abd00..64deeaddd51c 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4241,17 +4241,27 @@ static int pci_quirk_amd_sb_acs(struct pci_dev *dev, u16 acs_flags)
#endif
}

+static const u16 pci_quirk_cavium_acs_ids[] = {
+ /* CN88xx family of devices */
+ 0xa180, 0xa170,
+ /* CN99xx family of devices */
+ 0xaf84,
+ /* CN11xxx family of devices */
+ 0xb884,
+};
+
static bool pci_quirk_cavium_acs_match(struct pci_dev *dev)
{
- /*
- * Effectively selects all downstream ports for whole ThunderX 1
- * family by 0xf800 mask (which represents 8 SoCs), while the lower
- * bits of device ID are used to indicate which subdevice is used
- * within the SoC.
- */
- return (pci_is_pcie(dev) &&
- (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) &&
- ((dev->device & 0xf800) == 0xa000));
+ int i;
+
+ if (!pci_is_pcie(dev) || pci_pcie_type(dev) != PCI_EXP_TYPE_ROOT_PORT)
+ return false;
+
+ for (i = 0; i < ARRAY_SIZE(pci_quirk_cavium_acs_ids); i++)
+ if (pci_quirk_cavium_acs_ids[i] == dev->device)
+ return true;
+
+ return false;
}

static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags)
--
2.17.1