Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

[Xin Ji]

On Thu, Sep 19, 2019 at 08:57:12AM +0200, Neil Armstrong wrote:
> Hi,
> 
> On 19/09/2019 08:55, Xin Ji wrote:
> > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> > for portable device. It converts MIPI to DisplayPort 1.3 4K.
> > 
> > You can add support to your board with binding.
> > 
> > Example:
> > 	anx_bridge: anx7625@58 {
> > 		compatible = "analogix,anx7625";
> > 		reg = <0x58>;
> > 		anx,low_power_mode = <1>;
> > 		anx,dsi_supported = <1>;
> > 		anx,dsi_channel = <1>;
> > 		anx,dsi_lanes = <4>;
> > 		anx,internal_pannel = <1>;
> > 		anx,p-on-gpio = <&gpio0 45 GPIO_ACTIVE_LOW>;
> > 		anx,reset-gpio = <&gpio0 73 GPIO_ACTIVE_LOW>;
> > 		status = "okay";
> > 		port {
> > 			anx7625_1_in: endpoint {
> > 				remote-endpoint = <&mipi_dsi_bridge_1>;
> > 			};
> > 		};
> > 	};
> > 
> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/display/bridge/anx7625.txt | 42 ++++++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.txt b/Documentation/devicetree/bindings/display/bridge/anx7625.txt
> > new file mode 100644
> > index 0000000..f2a1c2a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.txt
> > @@ -0,0 +1,42 @@
> > +Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> > +-----------------------------------------------
> 
> New bindings should use yaml format:
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml
> 
> Neil
OK, I'll follow the yaml format in the next version.
Thanks,
Xin
> 
> > +
> > +The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > +designed for portable devices.
> > +
> > +Required properties:
> > +
> > + - compatible		: "analogix,anx7625"
> > + - reg			: I2C address of the device
> > + - anx,low_power_mode	: Low power mode support feature
> > + - anx,dsi_supported	: DSI or DPI
> > + - anx,dsi_channel	: DSI channel index
> > + - anx,dsi_lanes	: DSI lane count
> > + - anx,intr-hpd-gpio	: Which GPIO to use for interrupt
> > +
> > +Optional properties:
> > +
> > + - anx,extcon_supported
> > +	external connector interface support flag
> > + - anx,internal_pannel
> > +	Which indicate internal pannel
> > + - anx,p-on-gpio
> > +	Which GPIO to use for Power On chip
> > + - anx,reset-gpio
> > +	Which GPIO to use for RESET
> > + - port
> > +	SoC specific port nodes with endpoint definitions as defined in
> > +	Documentation/devicetree/bindings/media/video-interfaces.txt,
> > +
> > +Example:
> > +
> > +	anx_bridge: anx7625@58 {
> > +		compatible = "analogix,anx7625";
> > +		reg = <0x58>;
> > +		anx,low_power_mode = <0>;
> > +		anx,dsi_supported = <1>;
> > +		anx,dsi_channel = <1>;
> > +		anx,dsi_lanes = <4>;
> > +		anx,intr-hpd-gpio = <&gpio1 19 IRQ_TYPE_LEVEL_LOW>;
> > +		status = "okay";
> > +	};
> >