Re: [PATCH] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM

From: Arnd Bergmann
Date: Thu Sep 19 2019 - 08:11:01 EST


On Thu, Sep 19, 2019 at 7:19 AM Dexuan Cui <decui@xxxxxxxxxxxxx> wrote:
>
> If CONFIG_PM is not set, we can comment out these functions to avoid the
> below warnings:
>
> drivers/hv/vmbus_drv.c:2208:12: warning: âvmbus_bus_resumeâ defined but not used [-Wunused-function]
> drivers/hv/vmbus_drv.c:2128:12: warning: âvmbus_bus_suspendâ defined but not used [-Wunused-function]
> drivers/hv/vmbus_drv.c:937:12: warning: âvmbus_resumeâ defined but not used [-Wunused-function]
> drivers/hv/vmbus_drv.c:918:12: warning: âvmbus_suspendâ defined but not used [-Wunused-function]
>
> Fixes: 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation")
> Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation")
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

I think this will still produce a warning if CONFIG_PM is set but
CONFIG_PM_SLEEP is not, possibly in other configurations as
well.

Arnd