Re: [PATCH] ieee802154: atusb: fix use-after-free at disconnect

[Stefan Schmidt]

Hello.

On 19.09.19 14:12, Johan Hovold wrote:
> The disconnect callback was accessing the hardware-descriptor private
> data after having having freed it.
> 
> Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver")
> Cc: stable <stable@xxxxxxxxxxxxxxx>     # 4.2
> Cc: Alexander Aring <alex.aring@xxxxxxxxx>
> Reported-by: syzbot+f4509a9138a1472e7e80@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> 
> #syz test: https://github.com/google/kasan.git f0df5c1b
> 
>  drivers/net/ieee802154/atusb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> index ceddb424f887..0dd0ba915ab9 100644
> --- a/drivers/net/ieee802154/atusb.c
> +++ b/drivers/net/ieee802154/atusb.c
> @@ -1137,10 +1137,11 @@ static void atusb_disconnect(struct usb_interface *interface)
>  
>  	ieee802154_unregister_hw(atusb->hw);
>  
> +	usb_put_dev(atusb->usb_dev);
> +
>  	ieee802154_free_hw(atusb->hw);
>  
>  	usb_set_intfdata(interface, NULL);
> -	usb_put_dev(atusb->usb_dev);
>  
>  	pr_debug("%s done\n", __func__);
>  }
> 


This patch has been applied to the wpan tree and will be
part of the next pull request to net.

Thanks a lot for having a look at this!

regards
Stefan Schmidt