Re: [PATCH] ata: libahci_platform: Add of_node_put() before loop exit

From: Markus Elfring
Date: Thu Sep 19 2019 - 14:18:11 EST


> +++ b/drivers/ata/libahci_platform.c
> @@ -497,6 +497,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>
> if (of_property_read_u32(child, "reg", &port)) {
> rc = -EINVAL;
> + of_node_put(child);
> goto err_out;
> }

I suggest to move the added function call to another jump target.

- goto err_out;
+ goto err_put_node;
â
+err_put_node:
of_node_put(child);
err_out:
â


Regards,
Markus