Re: [PATCH v3 2/6] platform/x86: huawei-wmi: Add quirks and module parameters

From: Greg Kroah-Hartman
Date: Fri Sep 20 2019 - 02:08:23 EST


On Thu, Sep 19, 2019 at 08:39:07PM -0400, Ayman Bagabas wrote:
> Introduce quirks and module parameters. 3 quirks are added:
> 1. Fixes reporting brightness keys twice since it's already handled by
> acpi-video.
> 2. Some models need a short delay when setting battery thresholds to
> prevent a race condition when two processes read/write. (will be used later)
> 3. Matebook X (2017) handles micmute led through the "legacy" interface
> which is not currently implemented. Use ACPI EC method to control
> this led. (will be used later)
>
> 2 module parameters are added to enable this short delay and/or report
> brightness keys through this driver.

module parameters are a pain to manage and handle over time. Is there
any way you can "automatically" figure this out, or use a sysfs file
instead?

thanks,

greg k-h