Re: [PATCH] crypto: talitos - fix missing break in switch statement

From: Gustavo A. R. Silva
Date: Fri Sep 20 2019 - 04:18:49 EST


Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 9/10/19 01:06, Christophe Leroy wrote:
>
>
> Le 09/09/2019 Ã 07:29, Gustavo A. R. Silva a ÃcritÂ:
>> Add missing break statement in order to prevent the code from falling
>> through to case CRYPTO_ALG_TYPE_AHASH.
>>
>> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx>
>
>> ---
>> Â drivers/crypto/talitos.c | 1 +
>> Â 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
>> index c9d686a0e805..4818ae427098 100644
>> --- a/drivers/crypto/talitos.c
>> +++ b/drivers/crypto/talitos.c
>> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ break;
>> ÂÂÂÂÂÂÂÂÂ case CRYPTO_ALG_TYPE_AEAD:
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ crypto_unregister_aead(&t_alg->algt.alg.aead);
>> +ÂÂÂÂÂÂÂÂÂÂÂ break;
>> ÂÂÂÂÂÂÂÂÂ case CRYPTO_ALG_TYPE_AHASH:
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ crypto_unregister_ahash(&t_alg->algt.alg.hash);
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ break;
>>