Re: [PATCH 07/32] x86: Use pr_warn instead of pr_warning

[Kefeng Wang]

On 2019/9/20 17:28, Robert Richter wrote:
> On 20.09.19 14:25:19, Kefeng Wang wrote:
>> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
>> pr_warning"), removing pr_warning so all logging messages use a
>> consistent <prefix>_warn style. Let's do it.
>>
>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> Cc: Borislav Petkov <bp@xxxxxxxxx>
>> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
>> Cc: Robert Richter <rric@xxxxxxxxxx>
>> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
>> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
>> ---
>>  arch/x86/kernel/amd_gart_64.c          | 11 ++++---
>>  arch/x86/kernel/apic/apic.c            | 41 ++++++++++++--------------
>>  arch/x86/kernel/setup_percpu.c         |  4 +--
>>  arch/x86/kernel/tboot.c                | 15 +++++-----
>>  arch/x86/kernel/tsc_sync.c             |  8 ++---
>>  arch/x86/kernel/umip.c                 |  6 ++--
>>  arch/x86/mm/kmmio.c                    |  7 ++---
>>  arch/x86/mm/mmio-mod.c                 |  6 ++--
>>  arch/x86/mm/numa_emulation.c           |  4 +--
>>  arch/x86/mm/testmmiotrace.c            |  6 ++--
>>  arch/x86/oprofile/op_x86_model.h       |  6 ++--
> For oprofile:
>
> Acked-by: Robert Richter <rric@xxxxxxxxxx>
>
> But see below:
>
>>  arch/x86/platform/olpc/olpc-xo15-sci.c |  2 +-
>>  arch/x86/platform/sfi/sfi.c            |  3 +-
>>  arch/x86/xen/setup.c                   |  2 +-
>>  14 files changed, 57 insertions(+), 64 deletions(-)
>>
>> diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
>> index a585ea6f686a..53545c9c7cad 100644
>> --- a/arch/x86/kernel/amd_gart_64.c
>> +++ b/arch/x86/kernel/amd_gart_64.c
>> @@ -665,7 +664,7 @@ static __init int init_amd_gatt(struct agp_kern_info *info)
>>  
>>   nommu:
>>  	/* Should not happen anymore */
>> -	pr_warning("PCI-DMA: More than 4GB of RAM and no IOMMU\n"
>> +	pr_warn("PCI-DMA: More than 4GB of RAM and no IOMMU\n"
>>  	       "falling back to iommu=soft.\n");
> This indentation should be fixed too, while at it.
Will update later, thanks.
>
>>  	return -1;
>>  }
> -Robert
>
> .
>