Re: [Patch v2 10/13] media: am437x-vpfe: Remove print_fourcc helper

From: Benoit Parrot
Date: Fri Sep 20 2019 - 08:16:35 EST


Hans Verkuil <hverkuil@xxxxxxxxx> wrote on Fri [2019-Sep-20 10:21:17 +0200]:
> On 9/19/19 10:41 PM, Benoit Parrot wrote:
> > print_fourcc helper function was used for debug log to
> > convert a pixel format code into its readable form for display
> > purposes. But since it used a single static buffer to perform
> > the conversion this might lead to display format issue when more
> > than one instance was invoked simultaneously.
> >
> > It turns out that print_fourcc can be safely replace by using
> > "%4pE" instead and passing the pointer to the fourcc code.
>
> If this series is merged:
>
> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg149985.html
>
> then this patch needs to be rewritten. So I'll skip this patch for now.

Ok I'll monnitor the status of this patch and see if/when I'll rebase this
one.

Benoit

>
> Regards,
>
> Hans
>