Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

From: Krzysztof Kozlowski
Date: Fri Sep 20 2019 - 08:43:23 EST


On Fri, Sep 20, 2019 at 02:33:13PM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
>> +examples:
> >> + - |
> >> + #include <dt-bindings/clock/exynos-audss-clk.h>
> > Does it really work? When I tried, it was failing... If you look up at
> > resulting DTS example it is wrong.
>
> In which way it was wrong? We checked and it was correctly propagated to
> the example dts. It also compiled fine without errors. The only minor
> issue was that the include was generated inside the root node, but for
> the clock definitions this doesn't matter, but it makes the example
> easier to understand.

Hmmm.... indeed this works. The output DTS is weird as include goes to
example node (not even root) but it compiles. Somehow my previous tries
with it were failing, I need to check why. In general I am all in for
this include.

Best regards,
Krzysztof