Re: [PATCH 10/12] crypto: caam - populate platform devices last

From: Horia Geanta
Date: Fri Sep 20 2019 - 11:35:19 EST


On 9/4/2019 5:35 AM, Andrey Smirnov wrote:
> @@ -906,6 +900,13 @@ static int caam_probe(struct platform_device *pdev)
> debugfs_create_blob("tdsk", S_IRUSR | S_IRGRP | S_IROTH, ctrlpriv->ctl,
> &ctrlpriv->ctl_tdsk_wrap);
> #endif
> +
> + ret = devm_of_platform_populate(dev);
> + if (ret) {
> + dev_err(dev, "JR platform devices creation error\n");
> + return ret;
> + }
> +
> return 0;
> }
This is a bit better:

if (ret)
dev_err(dev, "JR platform devices creation error\n");

return ret;

Horia