Re: [PATCH] dimlib: make DIMLIB a hidden symbol

[Tal Gilboa]

On 9/20/2019 4:31 PM, Uwe Kleine-KÃnig wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
> 
> Signed-off-by: Uwe Kleine-KÃnig <uwe@xxxxxxxxxxxxxxxxx>
> ---
>   lib/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index cc04124ed8f7..9fe8a21fd183 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>   	  Implementation is done using GnuPG MPI library
>   
>   config DIMLIB
> -	bool "DIM library"
> -	default y
> +	bool
>   	help
>   	  Dynamic Interrupt Moderation library.
>   	  Implements an algorithm for dynamically change CQ moderation values
>
There's a pending series using DIM which didn't add the select clause 
[1]. Arthur, FYI. Other than that LGTM.

[1] https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg314304.html